fixed and optimized port data processing

Gidrolock Modbus Configurator.csproj

@@ -6,7 +6,7 @@
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
     <ProjectGuid>{47A399D3-30C1-4EF4-9E94-F3518919A59C}</ProjectGuid>
     <OutputType>WinExe</OutputType>
-    <RootNamespace>Gidrolock_Modbus_Configurator</RootNamespace>
+    <RootNamespace>Gidrolock_Modbus_Scanner</RootNamespace>
     <AssemblyName>Gidrolock Modbus Configurator</AssemblyName>
     <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>

Modbus.cs

@@ -14,7 +14,7 @@ namespace Gidrolock_Modbus_Scanner
     public static class Modbus
     {
         public static SerialPort port = new SerialPort();
-       
+
         public static event EventHandler<ModbusResponseEventArgs> ResponseReceived = delegate { };
 
         public static void Init()
@@ -276,7 +276,10 @@ namespace Gidrolock_Modbus_Scanner
         static int count = 0;
         static void PortDataReceived(object sender, EventArgs e)
         {
-            
+
+            //reset values on every event call;
+            buffer = new byte[255];
+            offset = 0;
             try
             {
                 stopwatch.Restart();
@@ -291,25 +294,15 @@ namespace Gidrolock_Modbus_Scanner
                     }
                 }
                 // assume that the message ended
-                offset = 0;
-                List <byte> message = new List <byte>();
-                int endOfMessage = buffer.Length - 1;
-                for (int i = buffer.Length-1; i >= 0; i--)
-                {
-                    if (buffer[i] != 0x00)
-                    {
-                        endOfMessage = i;
-                        break;
-                    }
-                }
-                for (int i = 0; i < endOfMessage + 1; i++)
+
+                List<byte> message = new List<byte>();
+                for (int i = 0; i < offset; i++)
                 {
                     message.Add(buffer[i]);
                 }
-                
                 if (message.Count == 0)
                     return;
-                
+
                 Console.WriteLine("Incoming message: " + ByteArrayToString(message.ToArray(), false));
                 /*
                 if (!CheckResponse(message.ToArray()))
@@ -345,7 +338,6 @@ namespace Gidrolock_Modbus_Scanner
         }
 
     }
-
     public class ModbusResponseEventArgs : EventArgs
     {
         public byte[] Message { get; set; }
@@ -365,7 +357,7 @@ namespace Gidrolock_Modbus_Scanner
                 }
                 //Console.WriteLine("Read data: " + Modbus.ByteArrayToString(Data, false));
             }
-            else Data = new byte[1] {0x0F};
+            else Data = new byte[1] { 0x0F };
         }
     }
 

Properties/AssemblyInfo.cs

@@ -30,6 +30,6 @@ using System.Runtime.InteropServices;
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("0.9.3.0")]
-[assembly: AssemblyFileVersion("0.9.3.0")]
+[assembly: AssemblyVersion("0.9.4.0")]
+[assembly: AssemblyFileVersion("0.9.4.0")]
 [assembly: NeutralResourcesLanguage("en")]

Properties/Resources.Designer.cs

@@ -8,7 +8,7 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
-namespace Gidrolock_Modbus_Configurator.Properties {
+namespace Gidrolock_Modbus_Scanner.Properties {
     using System;
     
     
@@ -39,7 +39,7 @@ namespace Gidrolock_Modbus_Configurator.Properties {
         internal static global::System.Resources.ResourceManager ResourceManager {
             get {
                 if (object.ReferenceEquals(resourceMan, null)) {
-                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Gidrolock_Modbus_Configurator.Properties.Resources", typeof(Resources).Assembly);
+                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Gidrolock_Modbus_Scanner.Properties.Resources", typeof(Resources).Assembly);
                     resourceMan = temp;
                 }
                 return resourceMan;

Properties/Settings.Designer.cs

@@ -8,7 +8,7 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
-namespace Gidrolock_Modbus_Configurator.Properties {
+namespace Gidrolock_Modbus_Scanner.Properties {
     
     
     [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]